Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature schedule #128

Merged
merged 25 commits into from
Apr 30, 2022
Merged

Feature schedule #128

merged 25 commits into from
Apr 30, 2022

Conversation

albertNos
Copy link
Collaborator

@albertNos albertNos commented Apr 19, 2022

featureNotebook -> featureSchedule

Description

  • LADDS inserts constellations based on startTime duration parameters from constellation config files (+config parameter referenceTime)
  • constellations constructor with config, constellationConfig (or rather read constellationConfig in satellite loader and pass all the arguments to Constellation in constructor?)
  • added constellation data that was supposed to be added in featureNotebook
  • id numberspaces for constellations (c1: 1,000,000, c2: 2,000,000 ...)
  • 2D schedule vector that is computed at initialization instead of during simulationLoop
  • constellations that start launch before reference time are inserted in quantity according to time difference

27.4 new ID distribution:

-new constructor for breakup wrapper that is compatible with new ID distribution
-new Simulation function: setConstellationsIDs() using new Constellation function moveConstellationsIDs()

Next PRs:

  • checkpointing with constellations
  • the test of the simulation with constellations (planned last)

@albertNos albertNos requested a review from FG-TUM April 19, 2022 08:36
Copy link
Collaborator

@FG-TUM FG-TUM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General things:

  • In the C++ code, change all new occurrences of snake_case to camelCase.
  • In Constellation.h go through the doc strings of all variables and clarify whether they are in "iterations", "Unix time", or something else.

cfg/default_cfg.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/ladds/particle/Constellation.cpp Outdated Show resolved Hide resolved
src/ladds/particle/Constellation.cpp Show resolved Hide resolved
src/ladds/particle/Constellation.cpp Outdated Show resolved Hide resolved
src/ladds/particle/Constellation.cpp Outdated Show resolved Hide resolved
src/ladds/particle/Constellation.cpp Outdated Show resolved Hide resolved
@albertNos albertNos requested a review from FG-TUM April 27, 2022 09:28
@albertNos albertNos merged commit 5c0ffea into main Apr 30, 2022
@FG-TUM FG-TUM deleted the featureSchedule branch May 4, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants