Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: amend incarnation logic #1746

Merged
merged 2 commits into from
Jan 16, 2024
Merged

core: amend incarnation logic #1746

merged 2 commits into from
Jan 16, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Jan 9, 2024

No description provided.

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Jan 9, 2024
@canepat canepat requested a review from yperbasis January 9, 2024 17:34
@yperbasis
Copy link
Member

It's worth changing the logic in Buffer::update_account so that it updates incarnations not only if account_deleted, but also when current->incarnation == 0 && initial->incarnation > 0, similar to erigontech/erigon#8954.

@canepat
core: cover corner case getting previous incarnation from last curren…
4e5518f 
…t one

node: cover corner case of initial smart account recreated as EOA
add unit tests
@canepat canepat merged commit d6d3d8a into master Jan 16, 2024
3 checks passed
@canepat canepat deleted the core_amend_incarnation_logic branch January 16, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yperbasis yperbasis yperbasis approved these changes

Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canepat @yperbasis