Fix startup sync for txpool processing for bor block production #9219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
approved these changes
Jan 12, 2024
taratorio
reviewed
Jan 12, 2024
yperbasis
added a commit
that referenced
this pull request
Jan 24, 2024
PR #9219 missed blockGasLimit. This PR fixes a failure in Hive test "Withdrawals Fork on Block 1 (Paris)" due to transactions excluded from block 1 because of failing `NotTooMuchGas` check.
yperbasis
added a commit
that referenced
this pull request
Jan 24, 2024
PR #9219 missed blockGasLimit. This PR fixes a failure in Hive test "Withdrawals Fork on Block 1 (Paris)" due to transactions excluded from block 1 because of failing `NotTooMuchGas` check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sync loop first runs it suppresses block sync events both in the initial loop and when the blocks being processed are greater than 1000.
This fix removed the first check, because otherwise the first block received by the process ends up not getting sent to the tx pool. Which means it won't produce new block for polygon.
As well as this fix - I have also moved the gas initialization to the txpool start method rather than prompting it with a 'synthetic block event'
As the txpool start has access to the core & tx DB's it can find the current block and chain config internally so that it doesn't need to be externally activated it can just do this itself on start up. This has the advantage of making the txpool more self contained.