Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devnet: fix ws port clash for state-sync scenario #9125

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

taratorio
Copy link
Member

@taratorio taratorio commented Jan 3, 2024

Getting an error in one of the bor nodes in devnet when trying to run the "state-sync" scenario:

[EROR] [01-03|16:55:44.179] cli.StartRpcServer error                 err="could not start separate Websocket RPC api at port 8546: listen tcp 127.0.0.1:8546: bind: address already in use"

This happens for scenarios with more than 1 node.

Digging further this regressions has happened due to this change: #8909

This PR fixes this by updating the devnet NodeArgs struct to set the corresponding --ws.port arg tag which now exists.

@taratorio taratorio requested a review from mh0lt January 3, 2024 17:56
@mh0lt mh0lt merged commit b94ca6d into devel Jan 3, 2024
7 checks passed
@mh0lt mh0lt deleted the fix-devnet-ws-port-clash branch January 3, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants