[Grindmas] Added tests to Beacon API, also fixed stuff. #9074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Giulio2002
commented
Dec 24, 2023
•
Giulio2002
commented
- Testing Beacon API
- Fixed sentinel code (a little bit)
- Fixed sentinel tests
- Added historical state support
- Fixed state-related endpoints (i was drunk when writing them)
Giulio2002
changed the title
elee1766
approved these changes
Dec 25, 2023
bayram98
approved these changes
Dec 25, 2023
| @@ -149,14 +78,13 @@ func TestSentinelGossipOnHardFork(t *testing.T) { | |||
| msg := []byte("hello") | |||
| go func() { | |||
| // delay to make sure that the connection is established | |||
| time.Sleep(time.Second) | |||
| time.Sleep(5 * time.Second) | |||
There was a problem hiding this comment.
can try set very small value - to reproduce some "race conditions"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.