Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snaps: stop merge to 500K and enjoy immutability #9034

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Conversation

AskAlexSharov
Copy link
Collaborator

No description provided.

@Giulio2002
Copy link
Contributor

Giulio2002 commented Dec 20, 2023

I want 100k snapshots not 500k, I do not think this PR is good. any reason why i should go with it?

@AskAlexSharov
Copy link
Collaborator Author

AskAlexSharov commented Dec 20, 2023

This pr does 100k

@Giulio2002
Copy link
Contributor

What did you change then?

@AskAlexSharov
Copy link
Collaborator Author

Copy link
Contributor

@elee1766 elee1766 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@elee1766 elee1766 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AskAlexSharov AskAlexSharov merged commit 7107cfe into devel Dec 21, 2023
6 checks passed
@AskAlexSharov AskAlexSharov deleted the no_merge branch December 21, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants