Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect statistics even for download completed or not started files #8956

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

dvovk
Copy link
Member

@dvovk dvovk commented Dec 11, 2023

No description provided.

@dvovk dvovk requested a review from awskii December 11, 2023 20:17
Copy link
Collaborator

@AskAlexSharov AskAlexSharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is mixed 2 things:

  • stat collecting
  • print logs

Logs need to be user-friendly: not too much of them, etc...

So,

peersRates := uint64(0)
// more detailed statistic: download rate of each peer (for each file)
if !t.Complete.Bool() && progress != 0 {
webseedRates := make([]interface{}, 0, len(weebseedPeersOfThisFile)*2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:= creating variable invisible from outside of scope

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@dvovk dvovk merged commit 3b68d57 into devel Dec 14, 2023
6 checks passed
@dvovk dvovk deleted the dvovk/snap_per_file branch December 14, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants