Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silkworm: disable in release binaries #8927

Merged
merged 1 commit into from
Dec 8, 2023
Merged

silkworm: disable in release binaries #8927

merged 1 commit into from
Dec 8, 2023

Conversation

battlmonstr
Copy link
Contributor

@battlmonstr battlmonstr commented Dec 7, 2023

A short-term safety measure to keep release.yml GH workflow unaffected.

@yperbasis
Copy link
Member

Why do this? Hopefully we can sort Silkworm issues out before we cut next release from devel.

@battlmonstr
Copy link
Contributor Author

battlmonstr commented Dec 7, 2023

@yperbasis There are a few things to be done to make it work properly: libsilkworm needs to be copied to the corresponding produced tar.gz files, test it in the release.yml workflow, and test that the resulting binaries work, also copy into docker images and test. I have it on my task list, but I wasn't sure I can sort this out in time before the next release. When is the next release devel cut-off planned?

@yperbasis
Copy link
Member

@yperbasis There are a few things to be done to make it work properly: libsilkworm needs to be copied to the corresponding produced tar.gz files, test it in the release.yml workflow, and test that the resulting binaries work, also copy into docker images and test. I have it on my task list, but I wasn't sure I can sort this out in time before the next release. When is the next release devel cut-off planned?

Right, I see. Not sure when the next release happens. Let's go with this change to be on the safe side.

@yperbasis yperbasis merged commit b86bdb7 into devel Dec 8, 2023
5 of 6 checks passed
@yperbasis yperbasis deleted the pr/noswrel branch December 8, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants