New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update outdated information #8906

Merged

AskAlexSharov merged 2 commits into erigontech:devel from ddl-hust:fix/readme-todo

Dec 6, 2023

Contributor

ddl-hust commented Dec 5, 2023

When running locally, found that these TODO json-rpc have been implemented. Updating these outdated information can make the document clearer.

curl -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_newBlockFilter","params":[],"id":1}' http://loca
lhost:8545
{"jsonrpc":"2.0","id":1,"result":"0x02000000000000009c49b60f431cabc7"}

[but it's easy to accomplish] Points to an obsolete message (https://github.com/ledgerwatch/erigon/blob/9b8cdc0f2289a7cef78218a15043de5bdff4465e/eth/downloader/downloader.go#L673)

ddl-hust added 2 commits

December 5, 2023 23:11


          clean todo

2672a3b


          chore: update outdated information

e7ce957

AskAlexSharov approved these changes

View reviewed changes

AskAlexSharov merged commit edcd7fc into erigontech:devel

6 checks passed

ddl-hust deleted the fix/readme-todo branch

December 6, 2023 02:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet