Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to Holesky config #8092

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Small fixes to Holesky config #8092

merged 1 commit into from
Aug 29, 2023

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Aug 29, 2023

Small fixes to PR #8064:

  • Don't set cancunTime for Holesky – otherwise we'll have to overwrite it later using the --override.cancun flag
  • We don't have block snapshots for Holesky yet
  • Add Holesky to isChainIDPoS

See eth-clients/holesky#68

@yperbasis yperbasis changed the title Small fixes for Holesky config Small fixes to Holesky config Aug 29, 2023
@yperbasis yperbasis merged commit 6362861 into devel Aug 29, 2023
4 checks passed
@yperbasis yperbasis deleted the holesky_no_snapshots branch August 29, 2023 14:29
AskAlexSharov pushed a commit that referenced this pull request Sep 6, 2023
Small fixes to PR #8064:

- Don't set cancunTime for Holesky – otherwise we'll have to overwrite
it later using the `--override.cancun` flag
- We don't have block snapshots for Holesky yet
- Add Holesky to `isChainIDPoS`

See eth-clients/holesky#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants