Fix ots_searchTransactions* rpc-tests #12357
Merged
+17
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if isFinalTxn { | ||
| continue | ||
| } | ||
|
|
||
| if mustReadHeader { | ||
| if header, err = api._blockReader.HeaderByNumber(ctx, tx, blockNum); err != nil { |
There was a problem hiding this comment.
@JkLondon after switching api of receiptsGenerator.GetReceipt from block to header - will need to update user's code to read header instead of block (where can).
AskAlexSharov
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12248
This PR retrofits the receipts generator and remove lots of custom code in order to fix the tests.
However it should be noticed that the receipts generator currently replays the entire block and doesn't consume the receipts domain, i.e., eth_getTransactionReceipt still suffers from the same issue.
From our conversation on Discord, Illya is working on it, so let's wait for his work be finished and we can retrofit his optimizations if needed.
Also, I'm reenabling all
ots_searchTransactions*rpc-tests, leaving onlyots_searchTransactionsBefore/test_13.jsonout. From my analysis so far, that one is breaking because of another unrelated exception, so I need more time to debug separately.