Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e3: bor.go has hack if len(events) == 50 to fallback to remote Heimdall #10310

Closed
AskAlexSharov opened this issue May 14, 2024 · 1 comment
Closed

e3: bor.go has hack if len(events) == 50 to fallback to remote Heimdall #10310

AskAlexSharov opened this issue May 14, 2024 · 1 comment
Assignees
@mh0lt
Labels
complexity:high Issue might take multiple weeks or more to fix erigon3 imp1 High importance polygon
Milestone
3.0.0-alpha3

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented May 14, 2024 •
edited
Loading

  • To validate/re-generate bor-mainnet event files - because of bor.go has hack if blockNum <= chain.Chain.FrozenBorBlocks() && len(events) == 50 { to fallback to remote Heimdall and without this hack execution doesn't work (after 46M on bor-mainnet and after 48M on Mumbai).

  • sometime this hack is not enough and need if blockNum <= chain.Chain.FrozenBorBlocks() && len(events) == 50 || len(events) == 0 { (but if degradating perf greatly)
@AskAlexSharov AskAlexSharov added this to the 3.0.0-alpha1 milestone May 14, 2024
@AskAlexSharov AskAlexSharov mentioned this issue Jun 2, 2024
Merged
AskAlexSharov added a commit that referenced this issue Jun 3, 2024
@AskAlexSharov
bor: no fallback to remote hack no chain tip (it's only useful with e…
d98d330 
…xisting bor files) (#10588)

related to #10310
we will gen new bor files after:
#10554 fix
@mh0lt mh0lt added the imp1 High importance label Jun 29, 2024
@AskAlexSharov AskAlexSharov mentioned this issue Jul 16, 2024
Closed
3 tasks
@AskAlexSharov AskAlexSharov added the complexity:high Issue might take multiple weeks or more to fix label Jul 26, 2024
@mh0lt
Copy link
Contributor

mh0lt commented Aug 19, 2024

In this PR: #9436 this extra code has been removed.

So far it has been texted on amoy and is currently being tested on bor-mainnet.

For now I'm assuming the issue is resolved - hence closing this issue. It can be re-opened if the underlying cause has not been fixed by the PR.

@mh0lt mh0lt closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mh0lt mh0lt

Labels
complexity:high Issue might take multiple weeks or more to fix erigon3 imp1 High importance polygon
Projects
None yet
Milestone
3.0.0-alpha3
Development

No branches or pull requests
2 participants
@AskAlexSharov @mh0lt