Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

consistency in idTypes #175

Open
ericblade opened this issue Aug 17, 2020 · 1 comment
Open

consistency in idTypes #175

ericblade opened this issue Aug 17, 2020 · 1 comment
Milestone

Comments

@ericblade
Copy link
Owner

image

@ericblade
Copy link
Owner Author

we also have similar in condition

type MWSItemCondition =
    | 'New'
    | 'Used'
    | 'Collectible'
    | 'Refurbished'
    | 'Club';

type AdvItemCondition =
    | 'used'
    | 'new'
    | 'collectible'
    | 'refurbished'
    | 'club';

I'm pretty sure we are converting it to lowercase intentionally, and also that some Amazon APIs are inconsistent in their usage. I think when I went through all the docs to write ts-amazon-mws, I was surprised at how inconsistent either their APIs or their documentation are.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant