-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DESIGN_KW
validation flag bug
#649
Conversation
Is there a good way of documenting that the option can still be set in the ert config? |
It is really important one can set the |
It is still the same, but the value is never passed to the DESIGN_KW script, it is only retrieved in the validate_forward_model_config step. The default value was passed to the script as a positional argument (without the |
Then it should be possible to use super().__init__(
name="DESIGN_KW",
command=["design_kw", "<template_file>", "<result_file>", "--validate=<VALIDATE>"],
default_mapping={"<VALIDATE>": "false"},
) |
Yes, but do we want to pass it to the script/have it as a script argument if it is unused? |
Yes, that seems unproblematic. |
This commit fixes the issue where the `<VALIDATE>=true` argument would be parsed as a positional argument instead of a keyword argument, and the arg parsed would raise an exception for unexpected argument `false`. After this commit, the <VALIDATE> argument is only for ert validation purposes, and is not forwarded to the `DESIGN_KW` argparser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This commit fixes the issue where the
<VALIDATE>=true
argument would be parsed as a positional argument instead of a keyword argument, and the arg parsed would raise an exception for unexpected argumentfalse
. After this commit, the argument is only for ert validation purposes, and is not forwarded to theDESIGN_KW
argparser.