Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Pydantic as dependency #476

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Remove Pydantic as dependency #476

merged 1 commit into from
Dec 22, 2023

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Dec 21, 2023

Resolves: #475

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec05d49) 95.18% compared to head (1bfe10e) 95.18%.

❗ Current head 1bfe10e differs from pull request most recent head 9093ff0. Consider uploading reports for the commit 9093ff0 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files          33       33           
  Lines        4461     4461           
=======================================
  Hits         4246     4246           
  Misses        215      215

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TeeeJay
Copy link

TeeeJay commented Dec 21, 2023

Sorry to bother, but would it make sense to add <3 or ^2 as a dependency resolver instead? That is what we in eCalc ...

@pinkwah
Copy link
Contributor Author

pinkwah commented Dec 21, 2023

I am not 100% sure about this, but I think ^2 is a Poetry thing and not Python. You are correct that it would be better to have an upper limit, but maintaining this without Poetry would be too difficult.

berland
berland reviewed Dec 21, 2023
View reviewed changes
setup.py Outdated
@@ -31,7 +31,7 @@
"autoapi",
"ipython",
"rstcheck",
"pydantic<2", # remove this when ert unpins fastapi and pydantic
"pydantic",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the entire line, as pydantic is a transitive dependency only.

@pinkwah pinkwah changed the title Unpin Pydantic Remove Pydantic as dependency Dec 21, 2023
berland
berland approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pinkwah pinkwah merged commit bb7a6db into equinor:master Dec 22, 2023
7 checks passed
@pinkwah pinkwah deleted the pydanticv2 branch December 22, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pydantic V2
4 participants
@pinkwah @codecov-commenter @TeeeJay @berland