-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Pydantic as dependency #476
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 33 33
Lines 4461 4461
=======================================
Hits 4246 4246
Misses 215 215 ☔ View full report in Codecov by Sentry. |
Sorry to bother, but would it make sense to add <3 or ^2 as a dependency resolver instead? That is what we in eCalc ... |
I am not 100% sure about this, but I think |
setup.py
Outdated
@@ -31,7 +31,7 @@ | |||
"autoapi", | |||
"ipython", | |||
"rstcheck", | |||
"pydantic<2", # remove this when ert unpins fastapi and pydantic | |||
"pydantic", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the entire line, as pydantic is a transitive dependency only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Resolves: #475