Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricten parsing of malformed parameter csv's with pandas>=1.4 #414

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Stricten parsing of malformed parameter csv's with pandas>=1.4 #414

merged 2 commits into from
Aug 22, 2022

Conversation

asnyv
Copy link
Collaborator

@asnyv asnyv commented Aug 19, 2022

Resolves #411

@asnyv
Copy link
Collaborator Author

asnyv commented Aug 19, 2022

Used index_col=False to avoid the pandas>1.4 behavior where 3 columns in the data and 2 defined names results in the first column being used as index.
Then catching the warning pandas writes when some data is dropped (column 3) and raise it as an error instead.

@asnyv asnyv marked this pull request as ready for review August 19, 2022 15:58
@asnyv
Copy link
Collaborator Author

asnyv commented Aug 19, 2022

also closes #399

@asnyv asnyv requested a review from berland August 22, 2022 06:52
berland
berland approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asnyv asnyv merged commit 4552f5d into equinor:master Aug 22, 2022
@asnyv asnyv deleted the pandas_1_4 branch August 22, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relax pandas old version requirement
2 participants
@asnyv @berland