Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve precision of datetime index using TIMESTEP #412

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Improve precision of datetime index using TIMESTEP #412

merged 3 commits into from
Aug 22, 2022

Conversation

asnyv
Copy link
Collaborator

@asnyv asnyv commented Aug 11, 2022 •
edited
Loading

Enhancement to tackle the issue described in #391

@asnyv asnyv marked this pull request as ready for review August 16, 2022 11:39
sigurdp
sigurdp approved these changes Aug 16, 2022
View reviewed changes
Copy link

@sigurdp sigurdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@asnyv asnyv requested a review from berland August 18, 2022 14:07
@codecov-commenter
Copy link

Codecov Report

Merging #412 (6d3f805) into master (2f01e0b) will decrease coverage by 0.10%.
The diff coverage is 83.33%.

❗ Current head 6d3f805 differs from pull request most recent head cb9e839. Consider uploading reports for the commit cb9e839 to get more accurate results

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   98.04%   97.94%   -0.11%     
==========================================
  Files          25       25              
  Lines        3430     3450      +20     
==========================================
+ Hits         3363     3379      +16     
- Misses         67       71       +4
Impacted Files Coverage Δ
ecl2df/summary.py 96.81% <83.33%> (-1.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@asnyv asnyv requested a review from berland August 19, 2022 15:59
@asnyv asnyv merged commit 56ac1fb into equinor:master Aug 22, 2022
@asnyv asnyv deleted the timestep branch August 22, 2022 08:23
@alifbe alifbe mentioned this pull request Oct 13, 2022
Closed
@asnyv asnyv mentioned this pull request Oct 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

@sigurdp sigurdp sigurdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asnyv @codecov-commenter @berland @sigurdp