Complump defaults set to 0 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 24 24
Lines 3318 3318
=======================================
Hits 3257 3257
Misses 61 61 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
This change should be propagated to https://github.com/OPM/opm-common/blob/master/src/opm/input/eclipse/share/keywords/000_Eclipse100/C/COMPLUMP as well. |
|
@berland. I have made a PR to fix this also in opm-common: OPM/opm-common#3006 |
|
@berland The change is now merged into opm-common: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default values of I, J, K1 and K2 in COMPLUMP should be 0 according to the manual. Defaulted values are still not implemented in the compdat module, but this give a better error message.