Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor construction of Eclipse input tables #381

Merged
merged 9 commits into from
Apr 26, 2023

Conversation

berland
Copy link
Collaborator

@berland berland commented Oct 20, 2021

The code in equil.py for printing an Eclipse input table has been generalized so it can be used for
other keywords.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #381 (b23b224) into master (81a24ac) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head b23b224 differs from pull request most recent head f7158c5. Consider uploading reports for the commit f7158c5 to get more accurate results

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   98.16%   98.18%   +0.02%     
==========================================
  Files          24       24              
  Lines        3318     3357      +39     
==========================================
+ Hits         3257     3296      +39     
  Misses         61       61              
Impacted Files Coverage Δ
ecl2df/common.py 99.71% <100.00%> (+0.05%) ⬆️
ecl2df/equil.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@berland berland requested a review from lindjoha October 28, 2021 07:02
@berland
Copy link
Collaborator Author

berland commented Mar 22, 2023

Comments:

  • Statements valid for py36/pandas 1.1.5 can be removed as of now
  • Only the equil module is directly affected by this PR, and should be tested sufficiently already.
  • This PR adds additional tests on the table generator using COMPDAT as an example, which is relevant for future feature enhancements to the COMPDAT module (and others).

@lindjoha lindjoha merged commit c05263b into equinor:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants