Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not configure root logger #208

Merged
merged 15 commits into from
Nov 26, 2020
Merged

Not configure root logger #208

merged 15 commits into from
Nov 26, 2020

Conversation

anders-kiaer
Copy link
Collaborator

No description provided.

@anders-kiaer anders-kiaer marked this pull request as ready for review November 20, 2020 12:38
@berland
Copy link
Collaborator

berland commented Nov 24, 2020

The --verbose options does not seem to work with this PR, this is how it is supposed to work:

$ ecl2csv grid -v  tests/data/reek/eclipse/model/2_R001_REEK-0.DATA 
INFO:ecl2df.grid:Extracting grjd geometry from EclFile("tests/data/reek/eclipse/model/2_R001_REEK-0.EGRID") at 0x1d82e20
INFO:ecl2df.grid:Merging zonemap into grid
INFO:ecl2df.grid:Extracting vectors ['*'] from INIT file
INFO:ecl2df.grid:Writing to file eclgrid.csv

@berland
Copy link
Collaborator

berland commented Nov 24, 2020

(and this illustrates that there should be a caplog test in the test suite for testing the verbose option)

@berland
Copy link
Collaborator

berland commented Nov 24, 2020

Adding logging.basicConfig() to ecl2csv.py and csv2ecl.py is perhaps the remedy?

@anders-kiaer
Copy link
Collaborator Author

Yes, the application part (i.e. not the library itself) can set logging options. I can add something closer to the console entrypoints.

tests/test_logging.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@berland berland merged commit d42fcd0 into equinor:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants