-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wsegaicd support #201
Merged
Merged
Wsegaicd support #201
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4e66e53
16.11.2020 (tklov): Added support for WSEGAICD and WSEGSICD in respon…
612cfa5
Add support for WSEGSICD and WSEGAICD in response to issue #199
2593b3d
wsegaicd-support added
9454880
Added code is black
1203d98
Manual flake8 fix
d2d0c77
Merge branch 'master' into wsegaicd-support
tklov11 68e4280
Corrections after review
09b70ff
Merge branch 'wsegaicd-support' of github.com:tklov11/ecl2df into wse…
71d625a
Merge branch 'master' into wsegaicd-support
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
{ | ||
"name": "WSEGAICD", | ||
"sections": [ | ||
"SCHEDULE" | ||
], | ||
"items": [ | ||
{ | ||
"name": "WELL", | ||
"value_type": "STRING" | ||
}, | ||
{ | ||
"name": "SEGMENT1", | ||
"value_type": "INT" | ||
}, | ||
{ | ||
"name": "SEGMENT2", | ||
"value_type": "INT" | ||
}, | ||
{ | ||
"name": "STRENGTH", | ||
"value_type": "DOUBLE" | ||
}, | ||
{ | ||
"name": "LENGTH", | ||
"value_type": "DOUBLE", | ||
"default": 12.0 | ||
}, | ||
{ | ||
"name": "RHO_CAL", | ||
"value_type": "DOUBLE", | ||
"default": 1000.25 | ||
}, | ||
{ | ||
"name": "MU_CAL", | ||
"value_type": "DOUBLE", | ||
"default": 1.45 | ||
}, | ||
{ | ||
"name": "CRIT_WATFRAC", | ||
"value_type": "DOUBLE" | ||
}, | ||
{ | ||
"name": "WIDTH_WATFRAC", | ||
"value_type": "DOUBLE" | ||
}, | ||
{ | ||
"name": "MAX_RATIO", | ||
"value_type": "DOUBLE", | ||
"default": 5.0 | ||
}, | ||
{ | ||
"name": "SCALING", | ||
"value_type": "INT", | ||
"dimension": -1, | ||
"default": 0 | ||
}, | ||
{ | ||
"name": "MAX_RATE", | ||
"value_type": "DOUBLE" | ||
}, | ||
{ | ||
"name": "VOLUME_RATE_EXP", | ||
"value_type": "DOUBLE", | ||
"default": 1.0 | ||
}, | ||
{ | ||
"name": "VISCOSITY_EXP", | ||
"value_type": "DOUBLE", | ||
"default": 1.0 | ||
}, | ||
{ | ||
"name": "FLAG", | ||
"value_type": "STRING", | ||
"default": "OPEN" | ||
}, | ||
{ | ||
"name": "OIL_FRAC_EXP_DENS", | ||
"value_type": "DOUBLE", | ||
"default": 1.0 | ||
}, | ||
{ | ||
"name": "WATER_FRAC_EXP_DENS", | ||
"value_type": "DOUBLE", | ||
"default": 1.0 | ||
}, | ||
{ | ||
"name": "GAS_FRAC_EXP_DENS", | ||
"value_type": "DOUBLE", | ||
"default": 1.0 | ||
}, | ||
{ | ||
"name": "OIL_FRAC_EXP_VISC", | ||
"value_type": "DOUBLE", | ||
"default": 1.0 | ||
}, | ||
{ | ||
"name": "WATER_FRAC_EXP_VISC", | ||
"value_type": "DOUBLE", | ||
"default": 1.0 | ||
}, | ||
{ | ||
"name": "GAS_FRAC_EXP_VISC", | ||
"value_type": "DOUBLE", | ||
"default": 1.0 | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
{ | ||
"name": "WSEGSICD", | ||
"sections": [ | ||
"SCHEDULE" | ||
], | ||
"items": [ | ||
{ | ||
"name": "WELL", | ||
"value_type": "STRING" | ||
}, | ||
{ | ||
"name": "SEGMENT1", | ||
"value_type": "INT" | ||
}, | ||
{ | ||
"name": "SEGMENT2", | ||
"value_type": "INT" | ||
}, | ||
{ | ||
"name": "STRENGTH", | ||
"value_type": "DOUBLE" | ||
}, | ||
{ | ||
"name": "LENGTH", | ||
"value_type": "DOUBLE", | ||
"default": 12.0 | ||
}, | ||
{ | ||
"name": "RHO_CAL", | ||
"value_type": "DOUBLE", | ||
"default": 1000.25 | ||
}, | ||
{ | ||
"name": "MU_CAL", | ||
"value_type": "DOUBLE", | ||
"default": 1.45 | ||
}, | ||
{ | ||
"name": "CRIT_WATFRAC", | ||
"value_type": "DOUBLE", | ||
"default": 0.5 | ||
}, | ||
{ | ||
"name": "WIDTH_WATFRAC", | ||
"value_type": "DOUBLE", | ||
"default": 0.05 | ||
}, | ||
{ | ||
"name": "SCALING", | ||
"value_type": "INT", | ||
"default": -1 | ||
}, | ||
{ | ||
"name": "MAX_RATE", | ||
"value_type": "DOUBLE" | ||
}, | ||
{ | ||
"name": "FLAG", | ||
"value_type": "STRING", | ||
"default": "OPEN" | ||
} | ||
] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this drop is not done for WELSEGS and COMPSEGS, for which WSEGxICD are analogues. So potentially it should not be done for WSEx*ICD or it should also be done for WELSEGS and COMPSEGS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, her har det skjedd noe feil. La meg sjekke litt og gjøre en pull-request til.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, WSEGxICD is analogous to COMPDAT with only one record, so I used COMPDAT as a template. WELSEGS and COMPSEGS have two records. KEYWORD_IDX is not defined in WELSEGS and COMPSEGS and therefore not dumped. If KEYWORD_IDX should have been defined/dumped for WELSEGS and COMPSEGS I think you should discuss with the developer for those keywords?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that sounds reasonable. Maybe that information should be included as a code comment.