Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WELOPEN support in ecl2df COMPDAT parsing #186

Merged
merged 16 commits into from
Oct 20, 2020
Merged

Add WELOPEN support in ecl2df COMPDAT parsing #186

merged 16 commits into from
Oct 20, 2020

Conversation

wouterjdb
Copy link
Contributor

No description provided.

@wouterjdb wouterjdb added the enhancement New feature or request label Oct 19, 2020
@wouterjdb wouterjdb self-assigned this Oct 19, 2020
@wouterjdb wouterjdb mentioned this pull request Oct 19, 2020
Merged
15 tasks
@wouterjdb wouterjdb marked this pull request as ready for review October 19, 2020 12:13
berland
berland reviewed Oct 19, 2020
View reviewed changes
ecl2df/compdat.py Outdated Show resolved Hide resolved
berland
berland reviewed Oct 19, 2020
View reviewed changes
ecl2df/compdat.py Outdated Show resolved Hide resolved
berland
berland reviewed Oct 19, 2020
View reviewed changes
tests/test_welopen.py Outdated Show resolved Hide resolved
berland
berland reviewed Oct 19, 2020
View reviewed changes
tests/test_compdat.py Outdated Show resolved Hide resolved
wouterjdb
wouterjdb commented Oct 19, 2020
View reviewed changes
Copy link
Contributor Author

@wouterjdb wouterjdb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INGORE this "review".

ecl2df/compdat.py Show resolved Hide resolved
ecl2df/compdat.py Show resolved Hide resolved
ecl2df/compdat.py Show resolved Hide resolved
ecl2df/compdat.py Outdated Show resolved Hide resolved
ecl2df/compdat.py Outdated Show resolved Hide resolved
ecl2df/compdat.py Show resolved Hide resolved
tests/test_compdat.py Outdated Show resolved Hide resolved
tests/test_welopen.py Outdated Show resolved Hide resolved
tests/test_welopen.py Show resolved Hide resolved
@berland
Copy link
Collaborator

berland commented Oct 20, 2020

One thing, can you add WELOPEN to the shell-script in opmkeywords/runmetoupdate.sh? And then rerunning the shell script manually should not make any changes (I think your submitted WELOPEN was identical)

berland
berland approved these changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@wouterjdb
Copy link
Contributor Author

Done.

Seems like there were some changes to files though (not WELOPEN). That should maybe be addressed in some other PR.

@berland
Copy link
Collaborator

berland commented Oct 20, 2020

Done.

Seems like there were some changes to files though (not WELOPEN). That should maybe be addressed in some other PR.

Yes, leave them for later.

@wouterjdb wouterjdb merged commit 479b68a into equinor:master Oct 20, 2020
@wouterjdb wouterjdb deleted the add-welopen-to-compdat2csv branch October 20, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees

@wouterjdb wouterjdb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wouterjdb @berland