Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let summary.df be able to always return datetime index #134

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Let summary.df be able to always return datetime index #134

merged 3 commits into from
Apr 16, 2020

Conversation

berland
Copy link
Collaborator

@berland berland commented Apr 14, 2020

Suggestion from #113

@berland berland requested a review from asnyv April 14, 2020 20:10
asnyv
asnyv approved these changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@asnyv asnyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Added a suggestion to split a word in a comment, but nothing important

tests/test_summary.py Outdated Show resolved Hide resolved
@berland @asnyv
Update tests/test_summary.py
17040d3 
Co-Authored-By: Asgeir Nyvoll <47146384+asnyv@users.noreply.github.com>
@berland berland merged commit 2d23627 into master Apr 16, 2020
@berland berland mentioned this pull request Apr 16, 2020
Closed
@berland berland deleted the return_datetime branch April 17, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnyv asnyv asnyv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berland @asnyv