Refactor Eclipse string construction in pyscallist. Bugfixes, testing and minor API change. #312

berland · 2021-09-23T13:01:23Z

No description provided.

pyscal/pyscallist.py

codecov-commenter · 2021-10-04T11:55:07Z

Codecov Report

Merging #312 (a39233a) into master (2e20069) will increase coverage by 0.79%.
The diff coverage is 92.17%.

❗ Current head a39233a differs from pull request most recent head b0420ab. Consider uploading reports for the commit b0420ab to get more accurate results

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   94.43%   95.23%   +0.79%     
==========================================
  Files          16       16              
  Lines        2478     2474       -4     
==========================================
+ Hits         2340     2356      +16     
+ Misses        138      118      -20

Impacted Files	Coverage Δ
pyscal/pyscallist.py	`95.09% <86.20%> (+1.47%)`	⬆️
pyscal/pyscalcli.py	`88.88% <90.00%> (+1.38%)`	⬆️
pyscal/factory.py	`97.81% <100.00%> (+0.54%)`	⬆️
pyscal/gasoil.py	`90.68% <100.00%> (-0.57%)`	⬇️
pyscal/utils/monotonicity.py	`99.14% <100.00%> (+3.31%)`	⬆️
pyscal/utils/relperm.py	`98.24% <100.00%> (+9.60%)`	⬆️
pyscal/utils/testing.py	`99.12% <100.00%> (+4.43%)`	⬆️
pyscal/wateroil.py	`95.96% <100.00%> (-0.02%)`	⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e20069...b0420ab. Read the comment docs.

jondequinor

Thanks for doing that refactor. Awesome.

Code-wise, this LGTM!

The API is currently kept, but will be removed later. pyscalcli is now responsible for file system interaction. Brush up pyscallist tests. Solve minor slgof-bug.

This is an API break, but in a very hidden corner

berland requested a review from eivindsm September 27, 2021 07:08

jondequinor suggested changes Oct 1, 2021

View reviewed changes

pyscal/pyscallist.py Outdated Show resolved Hide resolved

pyscal/pyscallist.py Outdated Show resolved Hide resolved

pyscal/pyscallist.py Show resolved Hide resolved

pyscal/pyscallist.py Show resolved Hide resolved

berland mentioned this pull request Oct 4, 2021

Subclass pyscallist #328

Open

berland changed the title ~~Bugfix and minor API change in pyscallist. Improve testing.~~ Refactor Eclipse string construction in pyscallist. Bugfixes, testoing and minor API change. Oct 4, 2021

berland changed the title ~~Refactor Eclipse string construction in pyscallist. Bugfixes, testoing and minor API change.~~ Refactor Eclipse string construction in pyscallist. Bugfixes, testing and minor API change. Oct 4, 2021

jondequinor approved these changes Oct 4, 2021

View reviewed changes

berland added 2 commits October 5, 2021 10:58

Refactor pyscallist output creation. Deprecate dump_family*() methods.

4a3dd2f

The API is currently kept, but will be removed later. pyscalcli is now responsible for file system interaction. Brush up pyscallist tests. Solve minor slgof-bug.

Remove non-needed function argument.

ea8cd34

This is an API break, but in a very hidden corner

berland force-pushed the test_pyscallist branch from b0420ab to ea8cd34 Compare October 5, 2021 08:59

berland merged commit e9fb245 into equinor:master Oct 5, 2021

berland deleted the test_pyscallist branch November 2, 2022 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Eclipse string construction in pyscallist. Bugfixes, testing and minor API change. #312

Refactor Eclipse string construction in pyscallist. Bugfixes, testing and minor API change. #312

berland commented Sep 23, 2021

codecov-commenter commented Oct 4, 2021

jondequinor left a comment

Refactor Eclipse string construction in pyscallist. Bugfixes, testing and minor API change. #312

Refactor Eclipse string construction in pyscallist. Bugfixes, testing and minor API change. #312

Conversation

berland commented Sep 23, 2021

codecov-commenter commented Oct 4, 2021

Codecov Report

jondequinor left a comment

Choose a reason for hiding this comment