Use ecl2df for summary file extraction #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
berland
force-pushed
the
use_ecl2df
branch
2 times, most recently
from
85661fc
to
b27978a
Compare
berland
force-pushed
the
use_ecl2df
branch
2 times, most recently
from
5d5cd66
to
243b50d
Compare
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 83.08% 83.61% +0.52%
==========================================
Files 14 14
Lines 2986 2948 -38
==========================================
- Hits 2481 2465 -16
+ Misses 505 483 -22
Continue to review full report at Codecov.
|
* realization.get_smry() has changed to always return a dummy index * cache_eclsum is pruned from fmu-ensemble.
This was referenced Mar 9, 2021
Closed
The argument column_keys is no longer accepted by get_smry_meta(). All smry metadata available to a realization/ensemble is now always returned by this function. This function is no longer the recommended practice for a client script to obtain the relevant summary vector metadata, API users should use the attrs["meta"] property of the returned summary dataframes instead.
ensemble.get_smr() will no longer ensure that the dates returned are identical in all realization, realizations with shorter timespans will not be extrapolated as they were before. This also affects get_smry_stats(), for which realizations which failed prematurely earlier had zero rates, affecting statistical profiles. Now these realization with truncated time-series will only affect the statistical profiles in the time-range they have data for.
asnyv
reviewed
Mar 17, 2021
Comment on lines
+868
to
+870
| logger.warning( | ||
| "Multiple UNSMRY files found, consider turning off auto-discovery" | ||
| ) |
There was a problem hiding this comment.
Not directly related to this PR, but I think this warning in the future at least should tell which file that was chosen, but I am a bit tempted to not accept it at all, and rather fail. The behavior is very risky...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API CHANGE
Left to do :
The 3D grid access functions is also a candidate for refactoring, if the functionality is still needed.