Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plotting of parameters from ensembles made with manual update #5700

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Jul 10, 2023

Issue
Resolves #5404

Approach
Sync storage after analysis step

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@JHolba JHolba self-assigned this Jul 10, 2023
@JHolba JHolba changed the title Sync storage after running analysis step Fix plotting of parameters from ensembles made with manual updates Jul 10, 2023
@JHolba JHolba added release-notes:bug-fix Automatically categorise as bug fix in release notes bug labels Jul 10, 2023
@JHolba JHolba changed the title Fix plotting of parameters from ensembles made with manual updates Fix plotting of parameters from ensembles made with manual update Jul 10, 2023
@JHolba
Copy link
Contributor Author

JHolba commented Jul 10, 2023

Plotter did not manage to show anything due to missing state-map.json. This caused storage to report all realisations as not initialised.

Copy link
Contributor

@pinkwah pinkwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #5700 (cc50366) into main (9e41444) will increase coverage by 37.75%.
Report is 23 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5700       +/-   ##
===========================================
+ Coverage   42.23%   79.98%   +37.75%     
===========================================
  Files          25      362      +337     
  Lines        3083    22515    +19432     
  Branches      989      989               
===========================================
+ Hits         1302    18008    +16706     
- Misses       1513     4239     +2726     
  Partials      268      268               
Files Changed Coverage Δ
src/ert/analysis/_es_update.py 88.21% <100.00%> (ø)

... and 336 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JHolba JHolba closed this Jul 28, 2023
@JHolba JHolba reopened this Jul 28, 2023
@JHolba JHolba merged commit d69ff89 into equinor:main Jul 28, 2023
59 checks passed
@JHolba JHolba deleted the sync_storage_after_update branch July 28, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Parameters not visible in Create plot when just parameters are in storage
3 participants