-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate Logs in RP2 input plugin #241
Comments
Strange, I'm not seeing it. Here's what I get with test_data.ods:
|
Thanks. There must be a bug in my current PR. I'll have to iron it out. |
@eprbell It seems to happen when I use the rp2 input plugin twice, with different descriptors, in the same config.ini file. I guess the rp2 input module is designed to only be used once? |
Sorry, just so I understand: do you mean you're using the same data loader plugin twice in the same DaLI .ini config file? If so, that's supported: e.g. if you have multiple Trezor wallets you would have multiple Trezor sections in the config file (with different qualifier to distinguish them). See https://github.com/eprbell/dali-rp2/blob/main/config/test_config.ini. |
Yeah, it should be supported, but there seems to be a bug for the rp2 data loader where if you use the data loader twice you get duplicate logs for both. |
I'm not seeing it when running RP2 on the DaLI outputs of https://github.com/eprbell/dali-rp2/blob/main/config/test_config.ini. Here is the RP2 output I get:
Can you attach a small repro file? |
I'm not sure if I can I think it has something to do with my latest PR. It looks like the CCXT converter is actually creating duplicate logs as well. I'm not sure why that is spilling out into the RP2 input processor, though. |
Can you try it on a freshly checked out tree? That'll help determine if the issue is with your PR or with the rest of the code. |
OK, it is duplicating the logs on pretty much everything except main. It is very odd problem. I don't think I can run my pull on the regular branch. I'd have to make up data, but let me see what i can do. |
There is no duplicate logs on the main branch. It is definitely a bug in the new PR. I'll close this and continue the conversation there. EDIT: I lied. There are no duplicate logs in ccxt on the main branch, but the RP2 input plugin still generates double logs. Let me put together a simple file that reproduces it. |
Here are two simple RP2 ODS files and a config.ini. You should be able to unzip in the root and test. |
I'm not sure if this is just an issue I'm having with my current configuration or if this is in the stable version, but I get duplicate logs when processing RP2 input:
Is anyone else getting this same bug?
Possible causes and What has been Attempted
I think this is being caused by two references pointing to the input plugin or the logger being instantiated twice? I'm not sure. I tried to make the RP2 plugin singleton and got the same issue.
The text was updated successfully, but these errors were encountered: