Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large file download warning not visible before accepting #240

Open
X1011 opened this issue Apr 20, 2024 · 2 comments
Open

Large file download warning not visible before accepting #240

X1011 opened this issue Apr 20, 2024 · 2 comments

Comments

@X1011
Copy link
Contributor

X1011 commented Apr 20, 2024

Ok, this will be my last issue report for now 😄
When I ran DaLI and got to the point where it downloads the Unified CSV File zip from Kraken, it did not show the message about what the file is that it's asking about. It seems like the progress bar rendered too early and overwrote the message, or maybe an output buffer needs to be flushed? This is the log (note the messages printed way to the right, after the progress bar:

INFO: Country: us
INFO: Initialized input plugin 'dali.plugin.input.csv.manual'
INFO: Initialized pair converter plugin 'dali.plugin.pair_converter.ccxt'
INFO: Reading crypto data using plugin 'dali.plugin.input.csv.manual'
INFO: Building manifest to optimize price calculation with the pair converters.
INFO: Resolving transactions
  0% |                                                                                                | Elapsed Time: 0:00:00 ETA:  --:--:--Do you want to download the file now?[yn]y

Above here outputted before I confirmed with 'y', and the following printed after:

INFO:
In order to provide accurate pricing from Kraken, a large (3.9+ gb) zipfile needs to be downloaded.
INFO: Downloading the unified CSV from https://drive.usercontent.google.com/download?id=16YKyFkYlvawCHv3W7WuTFzM8RYgMRWMt&export=download&confirm=t&uuid=f741c07c-64cf-4ee5-acf4-7b7f50309478
Downloading: |                                                        #                                              |   3.9 GiB  33.6 MiB/s
Downloading: |                                                        #                                              |   3.9 GiB  33.6 MiB/sINFO: Attempting to retrieve USDTUSD pair from the unified Kraken CSV file.
@macanudo527
Copy link
Collaborator

We probably have to insert a newline before the prompt I guess.

Did you resize your terminal window by any chance? Is this on windows, linux, macOS?

@X1011
Copy link
Contributor Author

X1011 commented Apr 23, 2024

I didn't try resizing the terminal. I'm on macOS Sonoma 14.4.1.

I'm actually having trouble reproducing it now: I ran it from a different directory without .dali_cache, but it just ran through and processed everything without downloading the CSV. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants