Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BitGet REST API Data Loader CCXT Plugin #200

Open
2 of 6 tasks
macanudo527 opened this issue Sep 12, 2023 · 4 comments
Open
2 of 6 tasks

Implement BitGet REST API Data Loader CCXT Plugin #200

macanudo527 opened this issue Sep 12, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@macanudo527
Copy link
Collaborator

macanudo527 commented Sep 12, 2023

Writing a DaLI data loader plugin has high impact on the functionality and usefulness of both DaLI and RP2. Data loader plugins are well-defined, encapsulated modules that translate native exchange REST API-based data into DaLI's standard format. As such they are good first issues for newcomers to the the project.

Before starting, please read the contributing guidelines.

Plugin development is described in the developer documentation, in particular read the Dali Internals and Plugin Development sections, which contain all the information needed to build a new data loader plugin.

BitGet REST API is documented here: https://bitgetlimited.github.io/apidoc/en/spot/#welcome

The Binance plugin can be used as an example.

Before submitting a PR for the new plugin, make sure to go through the DaLI Plugin Laundry List.

Id-based and page-based pagination will need to be implemented.

Tasks for this issue

  • Id-based Pagination
  • Page-based Pagination
  • Tests for Id-based Pagination
  • Tests for Page-based Pagination
  • BitGet REST API based on CCXT abstract plugin
  • Tests for BitGet REST API since it is using new pagination
@macanudo527 macanudo527 added the enhancement New feature or request label Sep 12, 2023
@macanudo527 macanudo527 self-assigned this Sep 12, 2023
@macanudo527
Copy link
Collaborator Author

This just got a lot easier. I found out BitGet has an API method for taxes that joins and pulls all relevant tax records. An exchange that actually makes it easier to do taxes! Go figure.

@eprbell
Copy link
Owner

eprbell commented Nov 17, 2023

Oh, interesting: what's the format like? BTW, unrelated, but thanks for going through all and trying to close all the old bugs that got fixed with your latest commits!

@macanudo527
Copy link
Collaborator Author

It just sorts all the transactions with a fee, amount and ticker. It then labels them appropriately, buys/sells, etc... Here's the link:

https://bitgetlimited.github.io/apidoc/en/spot/#spot-account-record

I haven't dove into the raw data yet, but looks pretty simple. It might be tough to match up buys and sells though.

@macanudo527
Copy link
Collaborator Author

In other news, CCXT has implemented an auto-pagination feature. Currently experimental, but will come in handy maybe next year-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants