-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 transactions with same uniqueID in binance #164
Comments
This is truly strange, the |
These are just regular trades? |
Can you elaborate on this? Curious why they should be the same. In any case since these are not transactions that need the resolver (they are a sale and a fee related to conversions), how about the following ideas:
Would this work? |
Sorry, I misread the CCXT codebase. They shouldn't be the same actually. I think this change will disambiguate the ids and it make it safe for all the other exchanges as well. |
will work with this /fee addition in abstract_ccxt_input_plugin?? |
@macanudo527 @eprbell Srry but not easy to me. Where shoud i fix it? |
i suppose is a binance issue, @macanudo527 maybe if same uniqueID and different asset pair, check orderid? as you mencioned in #157 ??
The text was updated successfully, but these errors were encountered: