This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix for extended_symbol 1.7.x #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndebord
previously approved these changes
Dec 18, 2019
heifner
reviewed
Dec 18, 2019
| @@ -443,13 +443,13 @@ namespace eosio { | |||
| * @return boolean - true if extended_symbol `a` is less than `b` | |||
| */ | |||
| friend constexpr bool operator < ( const extended_symbol& a, const extended_symbol& b ) { | |||
| return std::tie( a.symbol, a.contract ) < std::tie( b.symbol, b.contract ); | |||
| return std::tie( a.sym, a.contract ) < std::tie( b.sym, b.contract ); | |||
| } | |||
|
|
|||
| private: | |||
| symbol symbol; ///< the symbol | |||
There was a problem hiding this comment.
Missed changing this to sym
heifner
suggested changes
Dec 18, 2019
heifner
approved these changes
Dec 19, 2019
rise-worlds
pushed a commit
to potato-coin/eosio.cdt
that referenced
this pull request
Jul 14, 2020
….7.x fix for extended_symbol 1.7.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The current definition will produce an ABI for extended_symbol that will fail in abi_serializer.
API Changes
Documentation Additions