Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch:pkg] Fix setup.py encoding problem #145

Merged
merged 2 commits into from
Jan 16, 2021
Merged

[patch:pkg] Fix setup.py encoding problem #145

merged 2 commits into from
Jan 16, 2021

Conversation

Prhmma
Copy link
Contributor

@Prhmma Prhmma commented Jan 16, 2021

encoding problem in setup.py caused a problem installing the package from pip.
adding utf-8 solved it.

encoding problem caused problem installing the package from pip.
adding utf-8 solved it.
@eonu
Copy link
Owner

eonu commented Jan 16, 2021

Interesting... Can I ask which operating system you're on? And was it a warning that you got, or an error which stopped you from completely being able to install the package?

@Prhmma
Copy link
Contributor Author

Prhmma commented Jan 16, 2021

Interesting... Can I ask which operating system you're on? And was it a warning that you got, or an error which stopped you from completely being able to install the package?

I am using windows 10 and command prompt to install pip packages.
It was a "Charmap" error that breaks the installation in the beginning.

Capture

@eonu eonu changed the base branch from master to dev January 16, 2021 12:15
@eonu eonu changed the title encoding problem [patch:pkg] Fix setup.py encoding problem Jan 16, 2021
@eonu
Copy link
Owner

eonu commented Jan 16, 2021

Interesting... Can I ask which operating system you're on? And was it a warning that you got, or an error which stopped you from completely being able to install the package?

I am using windows 10 and command prompt to install pip packages.
It was a "Charmap" error that breaks the installation in the beginning.

Capture

Okay makes sense, I haven’t managed to get around to testing on Windows. Thanks!

@eonu eonu merged commit b6ae6e1 into eonu:dev Jan 16, 2021
This was referenced Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants