New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change self_attn_type #21

Closed

vince62s opened this issue Jun 11, 2024 · 0 comments · Fixed by #25

Labels

Contributor

vince62s commented Jun 11, 2024

I think it should be self_attn_backend, and should not be a model setting but a training setting on top of an inference setting

values should be: "flash2", "pytorch"
"pytorch" would include the sdpa_kernels used here: https://github.com/eole-nlp/eole/blob/main/eole/modules/multi_headed_attn.py#L637

we could test if flash2 is installed at training/inference start and adjust backend if necessary.

thus we could remove the flash2 setting from the MHA (redundant with self_attn_backend)

francoishernandez added the enhancement label

vince62s closed this as completed

francoishernandez linked a pull request

that will close this issue

review flash/sdpa arg #25

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment