Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Appveyor CI #292

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Stop using Appveyor CI #292

merged 1 commit into from
Jul 7, 2021

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Jul 6, 2021

This PR removes the appveyor configuration file and a related utility used to install edm on appveyor jobs. Two other similar scripts which are unused are also removed in this PR,

This PR is one step towards enthought/ets#63

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

This commit removes the appveyor configuration file and a related
utility used to install edm on appveyor jobs. Two other similar scripts
which are unused are also removed in this commit

	deleted:    appveyor.yml
	deleted:    install-edm-linux.sh
	deleted:    install-edm-osx.sh
	deleted:    install-edm-windows.cmd
@rahulporuri
Copy link
Contributor Author

Note that I updated the branch protection settings in this repository to remove "Appveyor CI" as a required check and instead include the GitHub Actions CI checks as required.

Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although it looks like CI is still unhappy with AppVeyor build failed even though it is no longer a required check

@rahulporuri
Copy link
Contributor Author

Although it looks like CI is still unhappy with AppVeyor build failed even though it is no longer a required check

Same mistake here as before - I didn't disable builds on branches without a configuration file - until after I created this PR.

@rahulporuri rahulporuri merged commit 0f98047 into master Jul 7, 2021
@rahulporuri rahulporuri deleted the cln/stop-using-appveyor-ci branch July 7, 2021 14:36
@rahulporuri
Copy link
Contributor Author

I removed the appveyor CI webhooks from this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants