Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Property depends_on with observe #289

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

aaronayres35
Copy link
Contributor

@aaronayres35 aaronayres35 commented Jun 14, 2021

Note these changes now make apptools require traits >= 6.2. I checked to specify this requirement, but it appears as though traits isn't even explicitly listed as a requirement, but rather is implicitly required through traitsui (which now explicitly requires traits >= 6.2). EDIT: I've added traits>=6.2.0 as an explicit required dependency on this PR.

apptools/setup.py

Lines 305 to 308 in 96c3af4

install_requires=[
'configobj',
'traitsui',
],

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit 9d87ac4 into master Jun 15, 2021
@aaronayres35 aaronayres35 deleted the replace-depends_on-with-observe branch June 15, 2021 12:27
@aaronayres35 aaronayres35 restored the replace-depends_on-with-observe branch June 15, 2021 12:27
@aaronayres35 aaronayres35 deleted the replace-depends_on-with-observe branch June 15, 2021 12:27
@aaronayres35
Copy link
Contributor Author

Agh, I forgot a news fragment. I will open a separate PR.

@rahulporuri
Copy link
Contributor

@aaronayres35 dunno if this is worth a news fragment - well maybe a news fragment mentioning that we now explicitly depend on traits >= 6.2.0.

@aaronayres35
Copy link
Contributor Author

aaronayres35 commented Jun 15, 2021

@aaronayres35 dunno if this is worth a news fragment - well maybe a news fragment mentioning that we now explicitly depend on traits >= 6.2.0.

I guess that is true, we have had changelog entries for otc-> observe changes in other packages, but they typically contain a list of all PRs involved, eg depends_on, dynamic and static handlers, _name_changed, etc. I guess I will just close #290 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants