Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebDispatcherImpl implementation issues #7523

Closed
4 tasks done
rymsha opened this issue Oct 9, 2019 · 0 comments
Closed
4 tasks done

WebDispatcherImpl implementation issues #7523

rymsha opened this issue Oct 9, 2019 · 0 comments
Assignees
@rymsha
Labels
Not in Changelog Tech Debt

Comments

@rymsha
Copy link
Contributor

rymsha commented Oct 9, 2019 •
edited
Loading

  • WebHandler.MIN_ORDER and WebHandler.MAX_ORDER are not respected

  • Every add/remove creates tons of garbage due to CopyOnWriteArrayList sorting

  • Needless method synchronization

  • Copying of list on every dispatch
@rymsha rymsha self-assigned this Oct 9, 2019
rymsha added a commit that referenced this issue Oct 9, 2019
@rymsha
WebDispatcherImpl implementation issues #7523
a79d359
GlennRicaud added a commit that referenced this issue Oct 9, 2019
@GlennRicaud
Merge pull request #7524 from enonic/issue-7523
cec6f9b 
WebDispatcherImpl implementation issues #7523
rymsha added a commit that referenced this issue Oct 10, 2019
@rymsha
Revert "WebDispatcherImpl implementation issues #7523"
c4756e8
GlennRicaud added a commit that referenced this issue Oct 10, 2019
@GlennRicaud
Merge pull request #7526 from enonic/revert-7524-issue-7523
e4087b0 
Revert "WebDispatcherImpl implementation issues #7523"
rymsha added a commit that referenced this issue Oct 10, 2019
@rymsha
WebDispatcherImpl implementation issues #7523
6290fda 
keep elements with same order
avoid copying on every dispatch
rymsha added a commit that referenced this issue Oct 10, 2019
@rymsha
WebDispatcherImpl implementation issues #7523
ce3021a 
keep elements with same order
avoid copying on every dispatch
rymsha added a commit that referenced this issue Oct 10, 2019
@rymsha
WebDispatcherImpl implementation issues #7523
5a40c4b 
keep elements with same order
avoid copying on every dispatch
rymsha added a commit that referenced this issue Oct 10, 2019
@rymsha
WebDispatcherImpl implementation issues #7523
c21b33d 
keep elements with same order
avoid copying on every dispatch
GlennRicaud added a commit that referenced this issue Oct 14, 2019
@GlennRicaud
Merge pull request #7528 from enonic/issue-7523
9238b62 
WebDispatcherImpl implementation issues #7523
@jsi jsi closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymsha rymsha

Labels
Not in Changelog Tech Debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsi @rymsha @GlennRicaud