Update bios for LiteSATA multi-sector read/write changes #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsomlo
force-pushed
the
gls-sata-multisector
branch
3 times, most recently
from
9595574
to
7fee181
Compare
|
@enjoy-digital -- Only "software/liblitesata: update to multi-sector read, write" is mandatory after LiteSATA PR 25 is applied. The other two: "software/bios/cmd_litesata: add multi-sector xfer between SATA and memory" and "software/bios/cmd_litesata: add multisector read/write test" are increasingly optional, and I'm OK if you drop or modify them before (or after) applying this PR :) Thanks, |
The LiteSATA gateware now supports multi-sector transfers, and expects a sector count register to be populated by the software before a DMA transfer is initiated. This patch also fixes checks for `done` and `error` during writes by using the correct `mem2sector` read function (instead of `sector2mem`, which is for use during read operations). Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
…mory Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
gsomlo
force-pushed
the
gls-sata-multisector
branch
from
7fee181
to
8dca488
Compare
gsomlo
added a commit
to litex-hub/linux
that referenced
this pull request
Jun 22, 2023
gsomlo
added a commit
to litex-hub/linux
that referenced
this pull request
Jun 23, 2023
gsomlo
added a commit
to litex-hub/linux
that referenced
this pull request
Jun 23, 2023
gsomlo
added a commit
to litex-hub/linux
that referenced
this pull request
Jun 27, 2023
|
Thanks @gsomlo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please only apply after enjoy-digital/litesata#25
Once the LiteSATA gateware is updated to accept a sector-count register, we can issue multi-sector read and write requests in a single DMA operation.
This PR also adds a pair of multi-sector SATAdisk - to - Memory transfer commands to the bios.