Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

RFC #0324 - Tracking for Deprecate Component#isVisible #22

Closed
1 of 6 tasks
kategengler opened this issue Feb 12, 2019 · 3 comments
Closed
1 of 6 tasks

RFC #0324 - Tracking for Deprecate Component#isVisible #22

kategengler opened this issue Feb 12, 2019 · 3 comments
Assignees
Labels
team:ember.js ember.js team

Comments

@kategengler
Copy link
Member

kategengler commented Feb 12, 2019

RFC #0324 - Tracking for Component#isVisible

Champion: @rwjblue


Expand for Instructions

All teams need to consider a merged RFC to plan any required work. Each team should comment on or edit this with links to issues for the work (or a note to the effect of "No work required").

See the README for more information
See #3 for an example

Under each team, for each repo requiring work for the RFC under that team:
### [repo name](repo url)

- [ ] (issue or pr) description, (issue or pr) link

Remove Repos that do not apply, conversely, there will probably be other repos that need work and should be added.

Ember.js Team:

ember.js

Ember CLI Team:

N/A

Ember Data Team:

N/A

Learning Team:

ember.js

  • check deprecated flag is displayed correctly in API Docs once deprecation is introduced
  • check that isVisible API description from the API Docs is removed successfully once deprecation is outlived

deprecation-app

guides-source

  • check guides-source for instances of isVisible and if applicable remove / replace the mentions in code examples with the alternative mentioned in the RFC

Steering Committee:

N/A

@jayjayjpg
Copy link
Member

Just had a quick look at the Guides and saw that there's no mention of Component#isVisible - we should be able to check this one off the list of learning items

@rwjblue
Copy link
Member

rwjblue commented Apr 19, 2019

@GavinJoyce has a PR up over in emberjs/ember.js#17948

@rwjblue rwjblue added needs planning:learning Needs planning by the learning team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team needs planning:ember.js Needs planning by ember.js team needs planning:steering committee Needs planning by the steering committee and removed needs planning:learning Needs planning by the learning team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team needs planning:steering committee Needs planning by the steering committee labels Apr 30, 2019
@MelSumner MelSumner removed the needs planning:learning Needs planning by the learning team label May 6, 2019
@kategengler kategengler removed the needs planning:ember.js Needs planning by ember.js team label May 22, 2019
@sandstrom
Copy link

@kategengler I think we can close this issue, or at least mark some subpoints as completed:

  • introduce deprecation
  • add a deprecation to the deprecations app

This was worked on in: emberjs/ember.js#17948

@rwjblue rwjblue closed this as completed Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team:ember.js ember.js team
Projects
None yet
Development

No branches or pull requests

5 participants