Update to use Ember.Array API... #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krisselden @mmun @raytiley would love a code review on this |
| this.set('_items', items); | ||
|
|
||
| if (items && items.addObserver) { | ||
| items.addObserver('[]', this, this._needsRevalidate); | ||
| if (items && items.addEnumerableObserver) { |
There was a problem hiding this comment.
What is the point of this?
There was a problem hiding this comment.
With the previous code, calling addObserver with a property of '[]'raised on error when used with an ArrayProxy.
There was a problem hiding this comment.
That sounds like a bug in ArrayProxy to be honest, also, addEnumerableObserver is soft deprecated and marked as private in 2.0. We can use addArrayObserver but to be honest I was adding a indirection here called dataSource so people could roll their own sparse array as part of the layout bin refactor but I'd like to pull this in for the mean time.
… PromiseArray's, etc Fixes #55
lukemelia
force-pushed
the
ember-arrays
branch
from
1a23cb1
to
02d4bcb
Compare
This was referenced Oct 10, 2015
krisselden
added a commit
that referenced
this pull request
Oct 11, 2015
Update to use Ember.Array API...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… so that it will work with ArrayProxy, PromiseArray, etc
Fixes #55