Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fetch should add code, status, and statusText to the thrown error #8899

Closed
gitKrystan opened this issue Sep 20, 2023 · 0 comments · Fixed by #8921
Closed

feat: Fetch should add code, status, and statusText to the thrown error #8899

gitKrystan opened this issue Sep 20, 2023 · 0 comments · Fixed by #8921
Assignees
@runspired
Labels
v4-to-v5 Tickets related to v4 to v5 migration paths

Comments

@gitKrystan
Copy link
Contributor

  • code to match the old Adapter semantics of InvalidError UnauthorizedError etc.
  • status to be the http status code as a string instead of number
  • statusText to be the http status text

We should possibly also consider a replacement for isAdapterError boolean for application code to be able to differentiate network errors from other application errors. e.g.

  • isRequestError: true
@runspired runspired added the v4-to-v5 Tickets related to v4 to v5 migration paths label Sep 23, 2023
@runspired runspired self-assigned this Sep 25, 2023
@runspired runspired mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runspired runspired

Labels
v4-to-v5 Tickets related to v4 to v5 migration paths
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Improved Fetch Errors emberjs/data
2 participants
@runspired @gitKrystan