Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octane - document fn and on helpers #828

Closed
jenweber opened this issue May 31, 2019 · 6 comments
Closed

Octane - document fn and on helpers #828

jenweber opened this issue May 31, 2019 · 6 comments

Comments

@jenweber
Copy link
Contributor

@sivakumar-kailasam is doing this. Thanks Siva!

@theroncross
Copy link
Contributor

Hi @sivakumar-kailasam - are you swapping out {{action}} usage for {{on <event> (fn <some-method>)}}, or just adding documentation? I see that these have been merged in 3.11 so I would think we'd want people to start using them instead of {{action}}. I'm happy to file a separate issue and PR if people think it's the right approach and you aren't already doing this.

@sivakumar-kailasam
Copy link
Member

@theroncross thanks for bringing this up.

The plan is to do both on the octane guides. Afaik we haven’t discussed porting over these to the main release docs.

I’ll bring this up in our weekly meeting tomorrow (feel free to join us if you can 🙂). You can follow along by reading the weekly meeting notes as well.

If you’re looking for other areas to help with then checkout our octane guides quest issue in case any of those interests you.

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Jul 4, 2019

@sivakumar-kailasam are still working on this? is there someway I can help?

edit: we talked on Discord, I have some spare cycles atm, so I'm going to tackle this

@sivakumar-kailasam
Copy link
Member

Thanks @NullVoxPopuli 🙏

@NullVoxPopuli
Copy link
Contributor

Work has begun over here: #912

@locks
Copy link
Contributor

locks commented Apr 30, 2020

Work finished :)

@locks locks closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants