Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofmt #751

Merged
merged 1 commit into from
Jun 17, 2018
Merged

gofmt #751

merged 1 commit into from
Jun 17, 2018

Conversation

whilei
Copy link
Contributor

@whilei whilei commented Jun 16, 2018

Just ran

gofmt -w .

on the project root. That's all.

https://blog.golang.org/go-fmt-your-code


I made this PR with a project going on over at https://github.com/rotblauer/gofmt-att, and it's definitely a work in progress. So if I got something wrong, or this is annoying at all, please file an issue over there and we'll sort it out.


This change is Reviewable

Run standard gofmt command on project root.

- go version go1.10.3 darwin/amd64

Signed-off-by: ia <isaac.ardis@gmail.com>
@elliotchance
Copy link
Owner

Thank you for running this. We already check gofmt as part of the build process (without the -w flag):

https://github.com/elliotchance/c2go/blob/master/travis/lint.sh#L5-L10

I'm pretty sure it runs against all packages but it's possible your version of gofmt is different. I will merge this in anyway. Every little bit helps! 😄


Review status: 0 of 1 files reviewed, all discussions resolved


Comments from Reviewable

@elliotchance
Copy link
Owner

Reviewed 1 of 1 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@elliotchance elliotchance merged commit ca11cc7 into elliotchance:master Jun 17, 2018
kamphaus pushed a commit to kamphaus/c2go that referenced this pull request Jun 20, 2018
elliotchance pushed a commit that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants