Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use templates for email body formatting for admin emails #1008

Open
5 tasks
gnott opened this issue Jan 20, 2020 · 0 comments
Open
5 tasks

Use templates for email body formatting for admin emails #1008

gnott opened this issue Jan 20, 2020 · 0 comments
Assignees

Comments

@gnott
Copy link
Member

gnott commented Jan 20, 2020

Emerging as an observation on PR #1006 where simple email body formatting was changed to use a template, there are other more lengthy emails that are not formatting with templates, including,

"... in PackagePoA, PublishFinalPOA, PubmedArticleDeposit, PubRouterDeposit, and a little in PublicationEmail."

There is also some question about whether these other emails could be expressed as simple string replacement templates or,

"... would possibly be better as jinja2 templates, but it may be possible to just use string replace templates."

@giorgiosironi commented,

"Do the templates contain conditionals or loops? That would be the Godzilla threshold that would call for Jinja or a similar full templating language."

This issue is a placeholder for further investigation and discussion, possibly leading to implementation of converting these email body formatting into template driven logic.

  • Do we want to convert the remaining email body logic functions into templates?
  • In terms of priority, when to do this?
  • Depending on the above, collect and analyse the existing emailing functions, look for commonalities and how template(s) could be used to satisfy the situations
  • Create the template(s)
  • Refactor programming logic, where possible, to use the template-based solution
@gnott gnott self-assigned this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant