Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead keys stopped working in the desktop version #7124

Closed
PureTryOut opened this issue Aug 1, 2018 · 9 comments
Closed

Dead keys stopped working in the desktop version #7124

PureTryOut opened this issue Aug 1, 2018 · 9 comments
Assignees
Labels
A-Electron P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Upstream

Comments

@PureTryOut
Copy link

Description

Since 0.16.0, dead keys have stopped working in the desktop version. It still works fine from the browser. With dead keys I mean characters like '. Characters using those characters (like é) still work fine.

Steps to reproduce

  • Set your keyboard layout to US International with dead keys.
  • Try to type a ' by pressing it twice.

Normally there would now be a ' character, but there won't be. This goes the same for ^, `, ~, and any other dead keys I can't think of right now.

Version information

  • Platform: web (in-browser) or desktop?

Desktop

For the desktop app:

  • OS: Gentoo Linux
  • Version: 0.16.0
@PureTryOut
Copy link
Author

Since this bug makes typing English sentences quite difficult, is there any way I can speed up fixing this issue? Is more info required maybe?

@dbkr
Copy link
Member

dbkr commented Oct 26, 2018

I just tried to repro this on Desktop v0.17.0, Ubuntu 16.04 (although in a VM) with the 'UK, international with dead keys' keyboard layout. Typing the backtick twice does give me a backtick character. Is this still a problem in Riot 0.17?

@PureTryOut
Copy link
Author

It definitely is. Try "US international with dead keys" layout instead. In my case it's mainly the ' character, which on that layout is beneath the ".

@aaronraimist
Copy link
Collaborator

aaronraimist commented Oct 26, 2018

After doing some testing, this seems to be a Chrome/Electron only issue. Firefox works.

It also doesn't appear to be an upstream bug as dead keys work in Chrome on https://www.slatejs.org/#/rich-text.

@dbkr backtick is the only one that does seem to work. Try ~ by pressing ~ and then space. Pressing it twice works.

@PureTryOut
Copy link
Author

Well, I did mention that it was on the desktop only (and thus Electron) in my initial report and title. I don't use Chrome so I don't know there, but it definitely works fine in Firefox.

I seem to recall I had trouble with more deadkeys, but I don't fully remember. At least ' is one that's broken, and it's also the one I use by far the most (it's used a lot in the English language of course) so it really annoys me a lot.

@aaronraimist
Copy link
Collaborator

Sorry, there are like 5 duplicate bugs here with #7440 (@lampholder can you combine these into one and close some as duplicates please?) so I don't know the full details of each.

Anyway, "Dead keys stopped working in the desktop version" is different from "Dead keys stopped working in the desktop version only". You said "It still works fine from the browser." but not which browser, so I am just clarifying.

@turt2live
Copy link
Member

I can't for the life of me get Gentoo up and running, so I've resorted to using Ubuntu 18.10. I think this is an upstream issue in Slate - I'm seeing random failures of being able to enter dead keys, which happens on both riot (firefox, chrome, or electron) and slate.

@turt2live
Copy link
Member

Because this happens on riot and slate, and is consistent with "IMEs don't work", I'm closing this in favour of #7665 to track the upstream issue.

@PureTryOut
Copy link
Author

I can't for the life of me get Gentoo up and running

But it has a nice well-written installation handbook, it isn't that hard ;) Doesn't seem to be OS related though, so Ubuntu should do fine.

I do notice that I had step 2 to reproduce it wrong, as pressing ' 2 times would give you ´. Instead on a US international dead key layout, you would press ' once and then a space to type it. The former ´ works still, but any key requiring the character to be typed first and then a space is broken (as you just get the space instead).

I'll subscribe to the other issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Electron P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Upstream
Projects
None yet
Development

No branches or pull requests

5 participants