Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser undo/redo greyed out doesn't match reality on Composer #7054

Closed
t3chguy opened this issue Jul 18, 2018 · 4 comments
Closed

browser undo/redo greyed out doesn't match reality on Composer #7054

t3chguy opened this issue Jul 18, 2018 · 4 comments
Labels
A-Composer T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@t3chguy
Copy link
Member

t3chguy commented Jul 18, 2018

originally reported as

Also the state of when the 'undo' menu action is available seems incorrect. Sometimes cmd+z works even when the undo menu item is greyed out(!)

in #7052 by @dbkr

I'm not sure this is something we can do about as Slate manages history itself instead of relying on the browser

@lampholder
Copy link
Member

You mean in the context menu? Is the 'undo' state displayed anywhere else?

@lampholder lampholder added T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter type:composer labels Jul 18, 2018
@t3chguy
Copy link
Member Author

t3chguy commented Jul 18, 2018

I believe thats what is meant yes
It is not currently shown but it could be as per: https://www.slatejs.org/#/history

@dbkr
Copy link
Member

dbkr commented Jul 19, 2018

(I meant in both the context menu and in the normal menu bar menu)

@t3chguy t3chguy changed the title Slate browser undo/redo greyed out doesn't match reality browser undo/redo greyed out doesn't match reality on Composer Mar 24, 2020
@kittykat
Copy link
Contributor

I can't reproduce this issue. If anyone knows how to, please add steps and reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

4 participants