Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILAG: Weird lack of spinner when viewing a room sometimes #4164

Closed
lukebarnard1 opened this issue Jun 2, 2017 · 1 comment
Closed

ILAG: Weird lack of spinner when viewing a room sometimes #4164

lukebarnard1 opened this issue Jun 2, 2017 · 1 comment

Comments

@lukebarnard1
Copy link
Contributor

This is consequential of both the RVS and the RV itself updating roomLoading. Previously, a room was considered loaded when peaking was successful. RVS now sets roomLoading to false once the room alias has been resolved.

Solution: use peekLoading or something to separate the state. roomLoading is a slight misnomer, it's more like roomAliasLoading.
@lukebarnard1
Copy link
Contributor Author

Actually this seems to be caused by something else. RoomViewhas coupled state.room and state.roomLoading such that a spinner will only displayed if room is falsey and roomLoading is true. But roomLoading becomes false once the alias has been resolved (by RoomViewStore) and not when the room becomes truthy.

@lukebarnard1 lukebarnard1 mentioned this issue Jun 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukebarnard1