Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Read-Only Users, redirect any attempt at an interactive action to the prompt to choose a username. #3608

Closed
lampholder opened this issue Apr 11, 2017 · 4 comments

Comments

@lampholder
Copy link
Member

lampholder commented Apr 11, 2017

The details of the new guest experience for Riot are on the project plan: element-hq/riot-meta#59

The user should be able to read the page unhindered, but any other action should trigger the username dialogue (#3604).

@lampholder lampholder added this to the RW003 milestone Apr 24, 2017
@lukebarnard1 lukebarnard1 changed the title Improve Landing as Guest: For Read-Only Users, redirect any attempt at an interactive action to the prompt to choose a username. For Read-Only Users, redirect any attempt at an interactive action to the prompt to choose a username. Apr 25, 2017
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented May 2, 2017

This is done in matrix-org/matrix-react-sdk#849 but needs refinement.

Here's a big list of all the things that need to change to SetMxIdDialog:

So the 11 instances contain descriptions:

  • "This room is private or inaccessible to guests. You may be able to join if you register.
  • "Guest users can't upload files. Please register to upload.
  • "Guests can't set avatars. Please register.
  • "Guests can't use labs features. Please register.
  • "Guest users can't invite users. Please register.
  • "Saving room color settings is only available to registered users
  • "This action cannot be performed by a guest user. Please register to be able to do this.
  • "Guest users can't upload files. Please register to upload.
  • "Guest users can't create new rooms. Please register to create room and start a chat.
  • "Guest users can't invite users. Please register to invite.
  • "This room is inaccessible to guests. You may be able to join if you register.

I'm now wondering whether we should bundle the description into SetMxIdDialog or whether we should just kill these.

@lukebarnard1 lukebarnard1 self-assigned this May 11, 2017
@lampholder
Copy link
Member Author

lampholder commented May 12, 2017

What does the UX look like for each of these if we replace the custom text with the To get started, please pick a username! dialogue and:

  • if the intercepted action is joining a room, make them join (if they permissions allow)
  • if the intercepted action is anything else, dump them back on the read-only room view/room directory (wherever they started) and let them try to perform that action again

"This room is private or inaccessible to guests. You may be able to join if you register.

If instead I see the generic pick-a-username popup, I will enter a username and click 'Continue', expecting to enter the room. If I can join I do and I'm happy. What happens if I can't?

"Guest users can't upload files. Please register to upload.

I think I can only trigger this by dropping a file on the room window, which I think is a bug. Non-participating users shouldn't be able to drop files on rooms - this fails even if you're not a guest.

"Guests can't set avatars. Please register.

Can an unregistered user access the UX to trigger this?

"Guests can't use labs features. Please register.

Can an unregistered user access the UX to trigger this?

"Guest users can't invite users. Please register.

Can an unregistered user access the UX to trigger this?

"Saving room color settings is only available to registered users

Could clicking the room settings cog trigger the pick a username dialogue? Then you'd just be dumped back on the read-only room view after picking your username, and you could click it again.

"This action cannot be performed by a guest user. Please register to be able to do this.

This is a very generic message - what action triggers this?

"Guest users can't create new rooms. Please register to create room and start a chat.

I enter my username, am dumped back where I started and click again to create a new room. Seems fine to me.

@lukebarnard1
Copy link
Contributor

"This action cannot...

This is actually setting power levels

@lampholder
Copy link
Member Author

Discussed IRL - decided we would bounce all actions (including clicking on user settings) to the mxid picker, without including any of the action-specific context for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants