Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTE] quoting a message that has a quote in it doesn't nest the quote properly #3444

Closed
uhoreg opened this issue Mar 15, 2017 · 2 comments
Closed

[RTE] quoting a message that has a quote in it doesn't nest the quote properly #3444

uhoreg opened this issue Mar 15, 2017 · 2 comments
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@uhoreg
Copy link
Member

uhoreg commented Mar 15, 2017

Description

See below.

Steps to reproduce

  • enable RTE
  • find a message that has a quote in it
  • click the menu button on the right of the message and select "Quote"
    image
  • see something like this in the composer area (sent message will appear similarly):
    image

Describe how what happens differs from what you expected.

The quoted portion of the original message should be nested, like:

test

test

Log: not sent

Version information

  • Platform: desktop

For the desktop app:

  • OS: Debian
  • Version: 0.9.7
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 P3 and removed P3 labels Mar 16, 2017
@lukebarnard1
Copy link
Contributor

whilst markdown supports nested quoting, draft-js native richtext quoting does not

@ara4n ara4n mentioned this issue May 21, 2018
Merged
33 tasks
@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

we support nesting now in matrix-org/matrix-react-sdk#1890, but quoting is broken for other reasons (#7034)

@ara4n ara4n closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@uhoreg @ara4n @lampholder @lukebarnard1