At-room notifications recently starting happening despite being disabled

[jryans]

Steps to reproduce

1. Use release version of Element Web without joining the notifications beta
2. Set "Messages containing @room" to "Off"
3. Receive an at-room message (such as this TWIM message)

Outcome

What did you expect?

I did not expect any notifications because I have at-room notifs disabled account-wide.

What happened instead?

A notification still came through.

Operating system

macOS 13.5.2

Browser information

Firefox 119

URL for webapp

app.element.io

Application version

Element version: 1.11.43 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

No

[jryans]

After some initial diagnosis by @t3chguy, it appears it's related to intentional mentions. The TWIM message I used as an example includes the new intentional mention metadata.

IIUC, intentional mentions like this use new push rules which are not controllable from the "old but still default" notifications UI.

[Johennes]

We already have rule syncing implemented for the polls push rules and I thought this should do the trick to do the same for the intentional mentions rules:

index fb81ac799e..ca60e6cf40 100644
--- a/src/notifications/VectorPushRulesDefinitions.ts
+++ b/src/notifications/VectorPushRulesDefinitions.ts
@@ -111,6 +111,9 @@ export const VectorPushRulesDefinitions: Record<string, VectorPushRuleDefinition
             [VectorState.Loud]: StandardActions.ACTION_HIGHLIGHT_DEFAULT_SOUND,
             [VectorState.Off]: StandardActions.ACTION_DISABLED,
         },
+        syncedRuleIds: [
+            RuleId.IsUserMention,
+        ]
     }),

     // Messages containing @room
@@ -122,6 +125,9 @@ export const VectorPushRulesDefinitions: Record<string, VectorPushRuleDefinition
             [VectorState.Loud]: StandardActions.ACTION_HIGHLIGHT,
             [VectorState.Off]: StandardActions.ACTION_DISABLED,
         },
+        syncedRuleIds: [
+            RuleId.IsRoomMention,
+        ],
     }),

It doesn't appear to work though. So I'm obviously missing something.

[Johennes]

@kerryarchibald can you spot what's wrong here?

[kerryarchibald]

The issue here is DEFAULT_OVERRIDE_RULES in pushprocessor, which is forcing the actions to the default value.

[Johennes]

Ah, thanks for figuring this out @kerryarchibald! 👍