Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a basic PR checklist to the major layers #22812

Closed
turt2live opened this issue Jul 11, 2022 · 1 comment
Closed

Add a basic PR checklist to the major layers #22812

turt2live opened this issue Jul 11, 2022 · 1 comment
Assignees
@turt2live
Labels
A-Developer-Experience T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

Things we want to cover:

  • Write tests
  • Fix the CI
  • Sign off on your changes

It was previously agreed that though a bit annoying for core contributors, it serves as a good reminder for what is important on a PR.
@turt2live turt2live added T-Task Tasks for the team like planning A-Developer-Experience labels Jul 11, 2022
@turt2live turt2live self-assigned this Jul 11, 2022
This was referenced Jul 11, 2022
Merged
Merged
This was referenced Jul 11, 2022
Merged
Merged
@turt2live
Copy link
Member Author

PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Developer-Experience T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live